Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note on the properties of an item and its cart state #10

Open
witekdev opened this issue Jul 8, 2016 · 5 comments
Open

note on the properties of an item and its cart state #10

witekdev opened this issue Jul 8, 2016 · 5 comments

Comments

@witekdev
Copy link
Contributor

witekdev commented Jul 8, 2016

Not so much of an issue per say but wanted to note down this behavior.

Let's say I add some item to the cart, then I update it's properties (like shipping weight) before checking the cart out. The checkout process does not take note of this updated property
and in my specific use case when I changed the shipping weight from 0 to 2 while I had some of those items sitting in the cart, I did not get taken to the shipping form (which I kind of expected since now the weight of each of those items was non-zero) but instead went directly to checkout.

I know that it is highly unlikely that a user will encounter such a scenario as they wont be checking out something and updating it's properties in mid process, nevertheless, something to be aware of.

@witekdev witekdev added the note label Jul 8, 2016
@davisagli
Copy link
Member

My thought was that we should honor the price (etc) that was configured when the item was added to the cart. But you could also argue that if someone leaves an item in their cart for a long time, we should use the current price. What do you think?

@witekdev
Copy link
Contributor Author

witekdev commented Jul 8, 2016

Hmm, you are right, changing the weight would affect the shipping price etc.
Well I would say honor the price that they got but as they are not yet on the shipping form (they have not begun to checkout process), if other properties like weight of the item change, update dynamically, or is that too much effort?

@witekdev
Copy link
Contributor Author

witekdev commented Jul 8, 2016

Amazon for instance lets you know that the price of the items in your cart has changed. Which I think is the best and acceptable way forward?

@davisagli
Copy link
Member

That's a feature that we can add if we have a client that is interested in paying for it, I'd say.

@witekdev
Copy link
Contributor Author

witekdev commented Jul 8, 2016

Sound good to me

@skleinfeldt skleinfeldt changed the title note on the properties of an item and it's cart state note on the properties of an item and its cart state Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants