You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The admin interface has an import function for Subscriptions. This uses the function make_subscription from admin_utils.py which makes it unnecessary hard to override the Subscription class (and still use the default admin.py.
I think make_subscription should be a method on Subscription - if you agree I could start a PR.
The text was updated successfully, but these errors were encountered:
Reading this function, I do not think it actually adds value over simply instantiating a Subscription. Feel free to fire a PR removing the function entirely, I think it'll result in the same lines of code, equal readability, less complexity and more adaptability (your purposes, I would expect).
The admin interface has an import function for Subscriptions. This uses the function make_subscription from
admin_utils.py
which makes it unnecessary hard to override the Subscription class (and still use the defaultadmin.py
.I think
make_subscription
should be a method onSubscription
- if you agree I could start a PR.The text was updated successfully, but these errors were encountered: