Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_subscriptions misplaced? #333

Open
frennkie opened this issue Sep 22, 2020 · 1 comment
Open

make_subscriptions misplaced? #333

frennkie opened this issue Sep 22, 2020 · 1 comment

Comments

@frennkie
Copy link
Collaborator

frennkie commented Sep 22, 2020

The admin interface has an import function for Subscriptions. This uses the function make_subscription from admin_utils.py which makes it unnecessary hard to override the Subscription class (and still use the default admin.py.

I think make_subscription should be a method on Subscription - if you agree I could start a PR.

@dokterbob
Copy link
Collaborator

Reading this function, I do not think it actually adds value over simply instantiating a Subscription. Feel free to fire a PR removing the function entirely, I think it'll result in the same lines of code, equal readability, less complexity and more adaptability (your purposes, I would expect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants