Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaml.js escape pattern is wrong: unnecessarily adds single quotes to strings that contain ':' #121

Open
desertkun opened this issue Nov 5, 2018 · 0 comments
Open

yaml.js escape pattern is wrong: unnecessarily adds single quotes to strings that contain ':' #121

desertkun opened this issue Nov 5, 2018 · 0 comments

Comments

@desertkun
Copy link

desertkun commented Nov 5, 2018 •
edited
Loading

But it shouldn't, at the colon is perfectly legal in YAML.

For example, this:

test::value: 5

Would get unnecessarily quoted:

'test::value': 5

The use case would be the Hiera relies on the :: to refer to the classes.
desertkun added a commit to anthill-utils/yaml.js that referenced this issue Nov 5, 2018
@desertkun
Fixes jeremyfa#121
65a9c80 
escape pattern is wrong: unnecessarily adds single quotes to strings that contain ':'
@desertkun desertkun mentioned this issue Nov 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@desertkun