Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM #171

Open
Tracked by #169
lishaduck opened this issue Jun 25, 2024 · 1 comment
Open
Tracked by #169

ESM #171

lishaduck opened this issue Jun 25, 2024 · 1 comment

Comments

@lishaduck
Copy link
Contributor

If elm-review moved to ESM, would you have problems?
elm-review HEAD requires Node 14, so Node supports elm-review. We don't expose an API, so this wouldn't be breaking there. As a CLI, it makes no difference.
I don't think anyone would care,1 but here's the issue.

On the elm-review side, this helps with TypeScript and exposing a public API (#170).

Footnotes

  1. Well, you might care philosophically, but ESM is the future, for better and for worse. If you hate ESM, that's perfectly fair. Nonetheless, that's not what this is about. This is "do you have code that this will break somehow" and eventually coordination.

This was referenced Jun 25, 2024
@lishaduck
Copy link
Contributor Author

This would require switching to Vitest, a more correct, prettier, and feature-complete test runner that competitively fast. Luckily, it's a drop-in replacement, so it should just be as easy as changing the imports and the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant