Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up new-package/ #178

Open
Tracked by #169
lishaduck opened this issue Jun 25, 2024 · 0 comments
Open
Tracked by #169

Clean up new-package/ #178

lishaduck opened this issue Jun 25, 2024 · 0 comments

Comments

@lishaduck
Copy link
Contributor

lishaduck commented Jun 25, 2024 •
edited
Loading

I haven’t read through the code enough here but there are many alarm bells ringing with the original code here:

  1. String interpolation in a shell command. Is spaces in the interpolated value going to mess it up?
  2. The use of npx.
  3. The use of child_process directly – does it work on Windows?

Originally posted by @lydell in #100 (comment)

Additionally, not all of the files are checked by ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lishaduck