Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffs could be improved by grouping blocks more #33

Open
jfmengels opened this issue Feb 3, 2021 · 0 comments
Open

Diffs could be improved by grouping blocks more #33

jfmengels opened this issue Feb 3, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jfmengels
Copy link
Owner

Diffs can sometimes look a bit off

In the examples above, we remove the whole function (one block of lines), but the diff algorithm that shows the before/after diff doesn't optimize for showing blocks of code when possible.

We're currently using (a vendored version of) jinjor/elm-diff.

If anyone is up for taking a look at improving that, that'd be awesome!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfmengels