Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner never stops #26

Open
linkdotnet opened this issue Aug 14, 2018 · 2 comments
Open

Runner never stops #26

linkdotnet opened this issue Aug 14, 2018 · 2 comments
Labels

Comments

@linkdotnet
Copy link
Member

After the server has stopped all remaining jobs stay alive.
All jobs should be closed / killed after a period of time.

@michaelschnyder
Copy link
Member

Thank you so much for your contributions so far @linkdotnet

There is actually a case where it makes sense that the runners dont quit: If the server is in an error state and restarts, the jobs can survive as long as they dont have to push any artefacts or update the job status.

Maybe a configuration option to specify the behaviour would not be bad.

@linkdotnet
Copy link
Member Author

I think a configuration would fit best in my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants