Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withDB doc's say "The returned handle should be released with close." #2

Open
unhammer opened this issue Feb 7, 2024 · 1 comment
Open

withDB doc's say "The returned handle should be released with close." #2

unhammer opened this issue Feb 7, 2024 · 1 comment

Comments

@unhammer
Copy link
Contributor

unhammer commented Feb 7, 2024

https://hackage.haskell.org/package/rocksdb-haskell-jprupp-2.1.6/docs/Database-RocksDB.html#v:withDB
typically with-functions do the closing for you. Is there a close function we should be calling, or are the docs wrong?
@jprupp
Copy link
Owner

jprupp commented Feb 7, 2024

It will be closed automatically when the with function it is out of scope.

unhammer added a commit to unhammer/rocksdb-haskell that referenced this issue Feb 8, 2024
@unhammer
Clarify withDB docs cf jprupp#2
dcf928b
jprupp added a commit that referenced this issue Feb 8, 2024
@jprupp
Merge pull request #3 from unhammer/master
e5a28a8 
Clarify withDB docs cf #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unhammer @jprupp