Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyinstrument 4.1.1 / python 3.11 & 3.12 compatibility #2

Open
BastienGauthier opened this issue Oct 16, 2023 · 2 comments · May be fixed by #4
Open

pyinstrument 4.1.1 / python 3.11 & 3.12 compatibility #2

BastienGauthier opened this issue Oct 16, 2023 · 2 comments · May be fixed by #4

Comments

@BastienGauthier
Copy link

Hello,

I am aware of the pyarrow blocker for streamlit full compatibility with python 3.12. I would like to mention another issue linked to pyinstrument here. The 4.1.1 version seems to be not compatible with python 3.12. Starting from 4.2 it works like a charm.

Would it be possible to bump the pyinstrument poetry version, as python 3.12 is now released ?

Cheers,
Bastien
@BastienGauthier BastienGauthier changed the title Python 3.12 compatibility pyinstrument 4.1.1 / python 3.12 compatibility Oct 16, 2023
@BastienGauthier BastienGauthier changed the title pyinstrument 4.1.1 / python 3.12 compatibility pyinstrument 4.1.1 / python 3.11 & 3.12 compatibility Oct 16, 2023
@BastienGauthier
Copy link
Author

@jrieke, would it work for you to drop the now obsolete python 3.7 support and updating the poetry requirement to something like :

[tool.poetry.dependencies]
python = "^3.8"
streamlit = "^1.0.0"
pyinstrument = "^4.2"

?

@jrieke
Copy link
Owner

jrieke commented Jan 10, 2024

In principle yes but I assume it would break some of the styling stuff. I'm not entirely sure anymore but I think that was the reason I pinned the version to 4.1.1 here. Unfortunately, I don't have time to look into this right now. If you want to, feel free to try out how it would look like with pyinstrument pinned to a more recent version (we should probably still stick to one pinned version so it doesn't break anything in the future). If there are no styling issues or if you can easily resolve them, I'm happy to review a PR.

(Note that if it requires major changes, I may not have the time to review the PR right now. You're still welcome to open it but no guarantees on when I'll get to it.)

wyattscarpenter added a commit to wyattscarpenter/streamlit-profiler that referenced this issue Jun 19, 2024
@wyattscarpenter
Update pyproject.toml: bump pyinstrument version to 4.2.0 for python …
86f0f49 
…3.11/3.12 compat

As discussed in jrieke#2
wyattscarpenter added a commit to wyattscarpenter/streamlit-profiler that referenced this issue Aug 11, 2024
@wyattscarpenter
Patch 1 (#1)
d829201 
* Update pyproject.toml: bump pyinstrument version to 4.2.0 for python 3.11/3.12 compat

As discussed in jrieke#2

* Update __init__.py: fix issue jrieke#3 by importing the components bit the newer way.

* Update pyproject.toml: bump patch version for changes

* Update requirements.txt: bump patch version for changes
@wyattscarpenter wyattscarpenter linked a pull request Aug 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jrieke @BastienGauthier