-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some extended attributes are supported but have no test coverage #207
Comments
This comment has been minimized.
This comment has been minimized.
domenic
pushed a commit
that referenced
this issue
Apr 26, 2020
For [LegacyLenientThis], this fixes an issue where it would still try to get the impl value, even when the thisArg did not pass the is() check, resulting in a TypeError. This also adds test coverage for [LegacyLenientThis] and [Replaceable], as part of #207.
domenic
pushed a commit
that referenced
this issue
Apr 26, 2020
For [LegacyLenientThis], this fixes an issue where it would still try to get the impl value, even when the thisArg did not pass the is() check, resulting in a TypeError. This also adds test coverage for [LegacyLenientThis] and [Replaceable], as part of #207.
domenic
pushed a commit
that referenced
this issue
Apr 26, 2020
For [LegacyLenientThis], this fixes an issue where it would still try to get the impl value, even when the thisArg did not pass the is() check, resulting in a TypeError. This also adds test coverage for [LegacyLenientThis] and [Replaceable], as part of #207.
domenic
changed the title
[LegacyLenientThis] and [LegacyOverrideBuiltins] are supported but don't have tests
Some extended attributes are supported but have no test coverage
Apr 29, 2020
I've renamed this issue and updated the OP to cover all untested extended attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In particular:
[Clamp]
[EnforceRange]
[LegacyNoInterfaceObject]
[LegacyOverrideBuiltins]
[PutForwards]
The text was updated successfully, but these errors were encountered: