Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple !import_file in a single JavaScript file (Perl) #2

Open
agiannone opened this issue Mar 12, 2013 · 1 comment
Open

Multiple !import_file in a single JavaScript file (Perl) #2

agiannone opened this issue Mar 12, 2013 · 1 comment

Comments

@agiannone
Copy link

I added two !import_file commands in a single JavaScript file and it failed to parse the content using the Perl script.

The JS file contained:

var css1 = "!import_file /file/path.css !important", css2 = "!import_file file/path2.css !important";

When performing the the replacement the Perl regex was matching the following string as the $filename:

"/file/path.css !important!import_file file/path2.css"

And was failing to find the file.

It would be great to be able to add two files to a single !import_file command.

@jugglinmike
Copy link
Owner

This sounds like a greedy matcher run amok. Thanks for reporting!

Unfortunately, I'm having trouble reproducing. I've written a test case that passes on my system. Would you mind checking out out the following branch and seeing if make test passes on your system?

https://github.com/jugglinmike/DressUp/compare/multi-file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants