Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parameter as first argument #66

Open
karaxuna opened this issue Sep 1, 2015 · 3 comments
Open

Error parameter as first argument #66

karaxuna opened this issue Sep 1, 2015 · 3 comments

Comments

@karaxuna
Copy link
Member

karaxuna commented Sep 1, 2015

In nodejs async functions we normally have first parameter as error and then other data. JXcore's loadMainFile function looks like this:

jxcore('app.js').loadMainFile(function(ret, err) {});

Should be:

jxcore('app.js').loadMainFile(function(err, ret) {});

Same is true for the callback of jxcore(...).call function.

@karaxuna karaxuna self-assigned this Sep 1, 2015
@obastemur
Copy link
Member

@karaxuna lets check this again and make this part of 0.1.0.0 (also mention on release logs as breaking feature)

@obastemur
Copy link
Member

Better also update the samples on 0.1.0.0 accordingly

@karaxuna
Copy link
Member Author

#114

@karaxuna karaxuna removed their assignment Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants