Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the RV semantics in Upstream Kubernetes #309

Open
nilekhc opened this issue Jul 11, 2024 · 1 comment
Open

Changing the RV semantics in Upstream Kubernetes #309

nilekhc opened this issue Jul 11, 2024 · 1 comment

Comments

@nilekhc
Copy link

nilekhc commented Jul 11, 2024

We are codifying the schema of ResourceVersion in upstream Kubernetes with KEP.

tl;dr
With this change, we are parsing ResourceVersion to an int, thus explicitly defining RV as an integer rather than an opaque string as it is today. Does this affect the project in any way?

@brandond
Copy link
Member

brandond commented Jul 11, 2024

I think we should be fine - our db schema and interfaces define it as int64:

type Log interface {
Start(ctx context.Context) error
CompactRevision(ctx context.Context) (int64, error)
CurrentRevision(ctx context.Context) (int64, error)
List(ctx context.Context, prefix, startKey string, limit, revision int64, includeDeletes bool) (int64, []*server.Event, error)
Count(ctx context.Context, prefix, startKey string, revision int64) (int64, int64, error)
After(ctx context.Context, prefix string, revision, limit int64) (int64, []*server.Event, error)
Watch(ctx context.Context, prefix string) <-chan []*server.Event
Append(ctx context.Context, event *server.Event) (int64, error)
DbSize(ctx context.Context) (int64, error)
Compact(ctx context.Context, revision int64) (int64, error)
}

Does defining it as int instead of int64 have any impact on 32bit platforms like arm, where int will be int32 instead of int64? We do still support arm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants