-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor's sticky header wrongly positioned #82
Comments
Hi @carlosesilva, Thank for you reporting an issue and helping improve Kaltura! To get the fastest response time, and help the maintainers review and test your reported issues or suggestions, please ensure that your issue includes the following (please comment with more info if you have not included all this info in your original issue):
and paste the output.
For general troubleshooting see: If you only have a general question rather than a bug report, please close this issue and post at: Thank you in advance, |
This fixes the issue discussed on the upstream repo: kaltura#82
Hello there,
I work for Boston University and we are in the process of integrating your plugin into our platform.
We have found an issue where the editor's header (sometimes the footer as well) gets absolute positioned in a weird spot. It happens if a post has enough content to trigger the editor's header sticky mode when you scroll down the edit page.
This issue was confirmed to happen on a fresh install of WordPress with only the all-in-one-video-pack plugin installed (confirmed on both v2.7 and v2.8-rc.4).
We have found that the issue gets fixed when we remove the css rule
body{ overflow: auto; }
found here: https://github.com/kaltura/all-in-one-video-pack.wordpress/blob/master/css/admin.css#L4I don't see why a plugin would need to add styles to the html and body tags anyways. Unless there is a very good reason to have them, I believe those styles should be removed so that this issue gets fixed. I will be submitting a pull request shortly after this with the proposed fix. In the mean time I will be adding some more information about the issue below.
How to reproduce the issue
Screenshots of the issue in action
Visual view
Text view
Environment tested on
The text was updated successfully, but these errors were encountered: