Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using raw macro in Ember 3.11 #570

Open
erikap opened this issue Aug 22, 2019 · 2 comments
Open

Error when using raw macro in Ember 3.11 #570

erikap opened this issue Aug 22, 2019 · 2 comments

Comments

@erikap
Copy link

erikap commented Aug 22, 2019

When combining computed macros including raw an error is thrown when passing the computed property to a component/helper in a template. Combining other macros than raw works fine.

E.g. supplementsAmount: sum(mapBy('model.supplements', raw('amount')))

causes the error

Error: Assertion Failed: EmberObject.create no longer supports defining computed properties. Define computed properties using extend() or reopen() before calling create().

The issue seems to be related to @bendemboski's review on kellyselden/ember-macro-helpers#260. When using

"ember-macro-helpers": "bendemboski/ember-macro-helpers#fix-ember-3-10"

the error disappears.

@lolmaus
Copy link
Contributor

lolmaus commented Sep 24, 2019

@bendemboski's branch has been merged.

Has this been resolved?

@erikap
Copy link
Author

erikap commented Sep 24, 2019

No, the branch has been merged with a modification that seems to break something. @bendemboski has put a comment about it on the PR kellyselden/ember-macro-helpers/pull/260.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants