Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting for BPF dataplane #69

Open
astoycos opened this issue Feb 8, 2023 · 1 comment
Open

Better error reporting for BPF dataplane #69

astoycos opened this issue Feb 8, 2023 · 1 comment
Labels
area/dataplane area/maintenance lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@astoycos
Copy link
Member

astoycos commented Feb 8, 2023

Today for all our TC BPF programs we execute our programs but ALWAYS return TC_ACT_OK regardless of the success or failure within our BPF program.
for example

#[classifier(name = "tc_ingress")]
pub fn tc_ingress(ctx: TcContext) -> i32 {
    match try_tc_ingress(ctx) {
        Ok(ret) => ret,
        Err(_) => TC_ACT_SHOT,
    };

    // TODO(astoycos) better Error reporting framework
    return TC_ACT_OK;
}

We should rethink this and at the very least let the user know that our programs failed in the event of a problem. I think a log would be fine for now.

@shaneutt shaneutt added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 12, 2023
@shaneutt shaneutt moved this to Backlog in Blixt Project Board Oct 12, 2023
@shaneutt shaneutt modified the milestones: v0.3.0 - Gateway API Conformance, v0.4.0 - Primary Features, v0.5.0 - Hardening Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@shaneutt
Copy link
Member

Not stale, just not ready for work yet as its intended for a later milestone (https://github.com/kubernetes-sigs/blixt/milestone/5).

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@shaneutt shaneutt modified the milestones: v0.7.0 - Hardening, v0.6.0 - Primary Feature Cleanup Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2024
@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2024
@shaneutt shaneutt added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 6, 2024
@shaneutt shaneutt removed this from the v0.8.0 - Hardening FIXME milestone Oct 29, 2024
@shaneutt shaneutt moved this from Hold to Backlog in Blixt Project Board Oct 29, 2024
@shaneutt shaneutt added this to the v0.8.0 - Hardening milestone Oct 29, 2024
@shaneutt shaneutt added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dataplane area/maintenance lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants