Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github pages to host official helm chart repository #1418

Open
jackfrancis opened this issue Apr 5, 2022 · 6 comments
Open

use github pages to host official helm chart repository #1418

jackfrancis opened this issue Apr 5, 2022 · 6 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jackfrancis
Copy link
Contributor

What would you like to be added:

This is a proposal to consider using the github pages feature to host the helm chart repo, rather than hosting it in a static directory in the repo. It looks like there is a gh-pages branch that hasn't been updated in over a year, so maybe we can use it for this?

I've had success in other projects using this github action to accomplish this goal:

https://github.com/helm/chart-releaser-action

Why is this needed:

Not 100% required, but would make helm chart downloads easier for users. Compare:

  • helm install --repo https://kubernetes-sigs.github.io/cloud-provider-azure/

to

  • helm install --repo https://raw.githubusercontent.com/kubernetes-sigs/cloud-provider-azure/master/helm/repo

The former (which is what a gh-pages-backed repo would look like) is cleaner IMO.

@jackfrancis jackfrancis added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 5, 2022
@MartinForReal MartinForReal added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 15, 2022
@jaanhio
Copy link

jaanhio commented Jun 4, 2022

hello @jackfrancis , i am happy to work on this if it isn't taken yet.

but one clarification i have is, is the intention to remove the existing hugo pages and replace it with hosting of helm chart repo or have both the hugo pages and helm chart repo hosted together?

@jackfrancis
Copy link
Contributor Author

I don't believe you can get both (the chart-releaser-action takes over the entire hugo implementation as far as I can tell).

cc @lzhecheng @feiskyer for permissions to overwrite the existing github pages content

@bridgetkromhout
Copy link

@jackfrancis This repo's ghpages branch is in use with some current updates now: https://github.com/kubernetes-sigs/cloud-provider-azure/tree/gh-pages

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2022
@Sajiyah-Salat
Copy link

is this pr still valid?

@feiskyer
Copy link
Member

yes, better to host with github pages, but we need to check how to host both charts and website together.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

8 participants