Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control NodeDrainTimeout #5159

Open
adrianbrasov opened this issue Oct 4, 2024 · 2 comments
Open

Control NodeDrainTimeout #5159

adrianbrasov opened this issue Oct 4, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@adrianbrasov
Copy link

adrianbrasov commented Oct 4, 2024 •
edited
Loading

/kind feature

Could we get a handle to control NodeDrainTimeout from ASO/Azure Managed MachinePools ?
CAPI has that exposed at MachinePool but it doesn't propagate to Azure ( using AzureManagedMachinePool as infra ref )
https://github.com/kubernetes-sigs/cluster-api/blob/9569cd60e39f2bef80a3a7b293b920cad4f052be/config/crd/bases/cluster.x-k8s.io_machinepools.yaml#L402
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 4, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 24, 2024

I remember taking a quick look at this a couple weeks ago and got the impression that this might be something that CAPI should handle generically across all providers. Are you seeing the correct behavior for any other provider (even the CAPI Docker one)?

@adrianbrasov
Copy link
Author

I haven't tested anything else, Azure is our only cloud provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
CAPZ Planning
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nojnhuh @k8s-ci-robot @adrianbrasov