Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tiltfile to differentiate between aks and kind cluster #5289

Open
Tracked by #5257
nawazkh opened this issue Nov 19, 2024 · 0 comments
Open
Tracked by #5257

Update Tiltfile to differentiate between aks and kind cluster #5289

nawazkh opened this issue Nov 19, 2024 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@nawazkh
Copy link
Member

nawazkh commented Nov 19, 2024

Tiltfile uses if "aks" in settings.get("kustomize_substitutions", {}).get("MGMT_CLUSTER_NAME", ""): to check if the tilt is being used with AKS cluster as a management cluster.
This is an inefficient approach. Especially when a user is switching from AKS -> KIND.

Suggested approach:

  • We want to have a local env based approach that gets set whenever make ads-create is called; and unset that env variable whenever make kind-create is called.
  • Once a similar logic is implemented, we want to update all the occurrences of if "aks" in settings.get("kustomize_substitutions", {}).get("MGMT_CLUSTER_NAME", ""): in the Tiltfile and use the env variable to check if it is a AKS cluster that is being used as a management cluster.
@nawazkh nawazkh changed the title Update tiltfile to know the mgmt cluster is aks Update Tiltfile to differentiate between aks and kind cluster Nov 19, 2024
@nawazkh nawazkh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: Todo
Development

No branches or pull requests

1 participant