You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @sbueringer observed in #2860 (comment),
we have, as of now, at least four different ways to wrap the client:
intercept.NewClient
NewDryRunClient
WithFieldOwner
WithStrictFieldValidation
... I think we should find a more scalable pattern to wrap clients.
If we continue to introduce a new wrapper for every single option we will end up with a lot of wrappers.
If we continue to introduce a new wrapper for every single option we will end up with a lot of wrappers.
I guess the same way we could either:
only have one wrapper taking various options and acting accordingly
This also makes the options more discoverable for users
Pretty sure we end up with more consistency then (see the list of wrappers below)
add options to the main client (that's probalby not good because then they cannot be used with the fake client)
/kind feature
The text was updated successfully, but these errors were encountered:
When building this we should also try to solve: #2967
All the wrappers we have don't properly deal with client.WithWatch and end up removing the Watch functionality.
As @sbueringer observed in #2860 (comment),
we have, as of now, at least four different ways to wrap the client:
/kind feature
The text was updated successfully, but these errors were encountered: