Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --output-file flag #145

Closed
mlavacca opened this issue Mar 21, 2024 · 5 comments · May be fixed by #150
Closed

Add --output-file flag #145

mlavacca opened this issue Mar 21, 2024 · 5 comments · May be fixed by #150
Assignees
@ipsum-0320
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mlavacca
Copy link
Member

What would you like to be added:

So far we have relied on redirecting the conversion output to a file. This has a major problem: if we log any message, such a message is dumped on the output file as well, polluting the .yaml/.json file.
To overcome this issue, we may want to introduce a new --output-file flag to allow users to dump the converted resources into a specific file and properly get log messages/warnings.

Why this is needed:

To separate output from logs.
@mlavacca mlavacca added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 21, 2024
@mlavacca mlavacca mentioned this issue Mar 21, 2024
Closed
@ipsum-0320
Copy link

/assign

ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 6, 2024
@ipsum-0320
feat: add --output-file flag (kubernetes-sigs#145)
17bac69
@ipsum-0320 ipsum-0320 mentioned this issue Apr 6, 2024
Open
ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 6, 2024
@ipsum-0320
feat: add --output-file flag (kubernetes-sigs#145)
610ff69
ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 6, 2024
@ipsum-0320
feat: add --output-file flag (kubernetes-sigs#145)
1a676d5
ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 6, 2024
@ipsum-0320
feat: feat: add --output-file flag (kubernetes-sigs#145)
33c2a26
ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 15, 2024
@ipsum-0320
fix: default output to console(kubernetes-sigs#145)
501c969
ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 16, 2024
@ipsum-0320
feat: add --output-file flag(kubernetes-sigs#145)
5fc17e8
ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 22, 2024
@ipsum-0320
feat: add --output-file flag(kubernetes-sigs#145)
d42332c
ipsum-0320 added a commit to ipsum-0320/ingress2gateway that referenced this issue Apr 22, 2024
@ipsum-0320
feat: add --output-file flag(kubernetes-sigs#145)
580b0fe
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 31, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipsum-0320 ipsum-0320

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --output-file flag (#145) ipsum-0320/ingress2gateway
4 participants
@k8s-ci-robot @mlavacca @k8s-triage-robot @ipsum-0320