Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webhook builder when controller-runtime allows overriding a mutation handler #3137

Open
alculquicondor opened this issue Sep 25, 2024 · 1 comment
Open

Remove webhook builder when controller-runtime allows overriding a mutation handler #3137

alculquicondor opened this issue Sep 25, 2024 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@alculquicondor
Copy link
Contributor

alculquicondor commented Sep 25, 2024 •
edited
Loading

What would you like to be cleaned:

Remove pkg/controller/jobframework/webhook/builder.go when kubernetes-sigs/controller-runtime#2932 is merged and released.

Why is this needed:

We duplicated the file to be able to provide a fix in Kueue faster in #3132
@alculquicondor alculquicondor added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 25, 2024
@alculquicondor
Copy link
Contributor Author

Do not assign this issue yet, because #3132 is not merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alculquicondor