Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to change kompose specific labels in k8s manifests #1960

Open
ontec-xrail opened this issue Nov 13, 2024 · 1 comment
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ontec-xrail
Copy link

What would you like to be added?

To remove the labels there is already an option:
--with-kompose-annotation=false

But there is still a label generated "io.kompose.service" - it would be cool to have another cmd line flag e.g. "--with-kompose-service-name=app" to get rid of the kompose specific stuff

Sample now:

apiVersion: v1
kind: Service
metadata:
  labels:
    io.kompose.service: xxxx-core
  name: xxxx-core
spec:
  ports:
    - name: "8080"
      port: 8080
      targetPort: 8080
  selector:
    io.kompose.service: xxxx-core

Sample later:
kompose convert --with-kompose-annotation=false --with-kompose-service-name=app ...

apiVersion: v1
kind: Service
metadata:
  labels:
    app: xxxx-core
  name: xxxx-core
spec:
  ports:
    - name: "8080"
      port: 8080
      targetPort: 8080
  selector:
    app: xxxx-core

Why is this needed?

generating a clean k8s manifest without kompose leftovers ...

@ontec-xrail ontec-xrail added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 13, 2024
@hangyan
Copy link
Contributor

hangyan commented Nov 18, 2024

sure, i will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants