Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PartialObjectMetadata for ConfigMaps and Secrets #2463

Open
mrueg opened this issue Aug 5, 2024 · 1 comment · May be fixed by #2468
Open

Use PartialObjectMetadata for ConfigMaps and Secrets #2463

mrueg opened this issue Aug 5, 2024 · 1 comment · May be fixed by #2468
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mrueg
Copy link
Member

mrueg commented Aug 5, 2024

What would you like to be added:
We should look into allowing to fetch only PartialObjectMetadata for these configmap/secrets objects.

Why is this needed:
ConfigMap objects can contain up to 1M of config or binary data. The metrics generated for the configmap is only relying on metadata.
Using PartialObjectMetadata will reduce memory consumption of KSM and require less network traffic.

For Secrets I think this will add the benefit that the secret data never is requested over the wire.

Describe the solution you'd like
Probably this metadatalister can be used instead of the ListWatch we use for other objects.
https://github.com/kubernetes/client-go/blob/71959c526d543a5e4c3ca6fb808f535c2726483f/metadata/metadatalister/lister.go

Additional context

@mrueg mrueg added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 5, 2024
@mrueg mrueg changed the title Use PartialObjectMetadata for ConfigMaps Use PartialObjectMetadata for ConfigMaps and Secrets Aug 5, 2024
@mrueg mrueg linked a pull request Aug 6, 2024 that will close this issue
@dgrisonnet
Copy link
Member

/assign @mrueg
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants