-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Pod concept into a simple introduction and further details #38867
Comments
/retitle Split Pod concept into a simple introduction and further details /triage accepted Yes, we should. Before starting work on this please reply here to outline your approach, and check that SIG Docs is happy with the approach you're considering. This is an important change to get right. |
I would like to contribute to this issue. And would like to seperate begineer concepts and advanced concepts of PODs. Regards, |
@devarsh10 A beginner's feelings are more useful when differentiating basic concepts from advanced concepts. |
Okay @tengqm. |
I have created rough notes of the points you mentioned. |
I had a look at the PDF. I'm afraid that it is a bit hard to understand that's in that fil;e, as the language isn't clear (it's not the kind of English that people speak around me). I'm worried that I can't work out the intent you have here @devash10, and so it's not easy to confirm that you're going in the right direction. |
Hey all, Regards. |
What we'd really like is either an editable document (HackMD, Google Doc) where approvers can make suggestions, or a pull request. I recommend opening an actual pull request. |
Hello @sftim, My plan is to make changes to the Kubernetes Pod documentation once the Google Doc is approved. Here's the link to the section I'll be editing: https://kubernetes.io/docs/concepts/workloads/pods/ Please let me know if you have any suggestions or if you think this approach could be improved. |
/help |
@sftim: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Help, from any contributor, is welcome. |
/assign |
Hello. I have a proposed fix, it doesn't require new content, just reshuffle and distribute what's already in the current index page. Current: 1 doc:
Proposed: 3 docs:
If there are no objections, I can draft a PR asap. Thanks! |
We don't [we try hard not to] split topics by audience expertise @mrgiles. See if you can find a different way to slice up these concepts. |
This is important work; however, changes are costly (people bookmark docs), so we like to avoid any need to redo things. That means we invest more effort in getting the reorganization right on the first go. My tips:
and more! |
Thanks for the tips, Tim. My bad, I've got the (wrong) impression that the request in this issue was to split the basic from the advanced content. If In the case of the Pods page, this could have links that lists pod-related content even outside its own section. Then dividing the content further into discrete docs (e.g., per topic) could be streamlined. The main task would then be how to outline this list. I'd go through your tips list to do that sorting. In a visual search, I've found the following Pod content across the site (I'm sure there's more), part of which could be linked from the landing page:
|
Tasks are one of [what we see as] the four kinds of documentation; Pods are not. I wouldn't make a landing page for Pods, but I would try to help someone find all of those pages with at most three clicks starting from https://k8s.io/docs/concepts/workloads/ or https://k8s.io/docs/concepts/containers/ IMO https://kubernetes.io/docs/concepts/workloads/pods/ is pretty usable, although there is room to make it better. |
Take 3...
|
Some suggestions:
This topic can be split out. There are in general two ways to manage a Pod, you can manipulate the Pod resource directly, or you can delegate that to a workload resource.
Maybe we want to combine this topic with the previous topic "Using Pods".
This is a field for advanced use cases. We may want to discuss this together with
Pod update and replacement can be reorganized based on the way you are managing them, right?
Both storage and networking are huge topics that warrant their own dedicated pages.
No. I don't think we want a page named "pod-stat-multi.md". If needed, I'd suggest we add a page "static-pods.md". In that page, we explain the concept, their target use cases, how are they discovered, what are shadow Pods, how are they restarted, their limitations (e.g. references to other resources ...). Pods with multiple containers? That is a different topic. We can discuss the resource sharing and intra-pod communication there.
I believe we already have a dedicated page on probes. We often receive questions related to probes. Why don't we consolidate them into a single concept page?
|
I like that last suggestion. If you're now convinced @shirady, I suggest you open new issues about each improvement that you support from the outline in #38867 (comment) and close this one. In other words, don't use this issue as an umbrella issue; “make Pod pages better“ just feels really broad, and might end up with a lot of comments! A detail I think is important - |
What I'm suggesting is: a set of new issues, each one capturing a single chunk of the outline @tengqm made earlier - see #38867 (comment) That will let different authors work on separate packages of the work we're planning. Also, let's say one specific part of that plan does need discussion, we can get on with the other issues from the design without waiting to get every detail agreed. The perfect is the enemy of the good. |
If folks want to make a PR that aligns with the overall idea, getting ahead of the issue tracking work: you can! It's open source, and help of all kinds is usually very welcome. |
@sftim I'm not sure I understand what you suggested to exactly add in the new issue. |
I think this page needs to be separated, today it includes basic information about pods as well as detailed advanced subjects.
https://k8s.io/docs/concepts/workloads/pods/
This page should include:
... all the rest are detailed advanced subjects, and if someone did not know what is a pod, he will hardly understand those details.
The text was updated successfully, but these errors were encountered: