-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental LaTeX parser and renderer in book example #45
Draft
zeozeozeo
wants to merge
17
commits into
lampsitter:master
Choose a base branch
from
zeozeozeo:latex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still no proper error handling, just unwraps
* Proper list wrapping (comrak backend) * Proper list wrapping (pulldown_cmark backend) * Cleanup * Add prettier spacing between list and items * Changelog and doc
Fixes lampsitter#44 This allows them to be used in lists. The same fix has been applied to blockquotes, but they require some more work to their visuals to render properly in lists.
still no proper error handling, just unwraps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented using the new
pulldown_cmark
0.11 version which supports simple math parsing (which is still not published, so for now we pull it from Git)The renderer calls out to MathJax with mathjax_svg (which embeds the V8 engine into the executable and uses MathJax to convert LaTeX into an svg). This is then rendered as an egui image using
egui_extra
'ssvg
feature (which uses Resvg).This doesn't really have to be LaTeX, since the entirety of rendering math expressions is handled by the user, not egui_commonmark. Never really tried to mess with Typst, but it could be entirely possible to implement it.
TODO: proper error handling,
math
feature, center text horizontally with math equations, select and copy equations, implement Typst renderingcloses #25