Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composed-tox-sonar-cloud.yaml is broken #177

Open
zxiiro opened this issue Jul 29, 2024 · 1 comment
Open

composed-tox-sonar-cloud.yaml is broken #177

zxiiro opened this issue Jul 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@zxiiro
Copy link
Member

zxiiro commented Jul 29, 2024

It seems the workflow composed-tox-sonar-cloud.yaml is broken and throws the following error:

Error
reusable workflows should be referenced at the top-level `jobs.*.uses' key, not within steps

Looks like there is a misconfiguration in the yaml somewhere.

@ModeSevenIndustrialSolutions
Copy link
Contributor

ModeSevenIndustrialSolutions commented Sep 26, 2024

You're right, it's because the tox-verify workflow is being called from a step, whereas re-usable workflows have to be called as self-contained/top-level jobs. I suspect the subsequent step:

- name: Run Sonar Cloud scan
  uses: sonarsource/sonarcloud-github-action@master

...needs to be merged into a single core workflow, where the two steps can be called together? We'll need to check where it is being used though, as changing the behaviour might cause unintended breakage. However, I suspect the tox-verify step might instead be better constructed as an action, which would also solve the problem?

@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions added the bug Something isn't working label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants