Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version maturity - the 'age' Marshall checks since package created. This feature is for new version published time difference. #311

Open
robatwilliams opened this issue Jul 3, 2024 · 4 comments

Comments

@robatwilliams
Copy link

Warn when the version being installed has only very recently been published. That would invite extra caution because scanners and the community may not yet have found any newly introduced issues.

Expected Behavior

Warning on the next line after "Checking package maturity" if published less than e.g. 1 day ago

Current Behavior

No change, only additional.

Possible Solution

The publish date is available in the package metadata (npm info).

Context

For example when node-ipc was compromised, there was a time window until the issue was identified, and if you happened to install during that window then you would have been impacted.

The counterpoint to this whole idea however is that if everyone holds off installing recently published versions, it could delay identification of security issues.

@lirantal
Copy link
Owner

lirantal commented Jul 5, 2024

Hi @robatwilliams, thanks for the idea but this is already implemented. See the README for age Marshall. The default is 22 days:

image

That is relevant to the whole package time diff from being created (published for the first time).
Are you asking specifically about a new version publish time difference?

@robatwilliams
Copy link
Author

Yes, the age of the new version

@lirantal lirantal changed the title Version maturity Version maturity - the 'age' Marshall checks since package created. This feature is for new version published time difference. Jul 5, 2024
@lirantal
Copy link
Owner

lirantal commented Jul 5, 2024

Ok.
What would be a good time diff threshold?

@robatwilliams
Copy link
Author

Hard to say. If it's too low then any package that's frequently releasing patches will always get a warning. But I don't think there always being a warning would be a new issue, as most packages already don't have a provenance statement.

7 days perhaps? It would almost effectively be 5 days if the publish was done just before the weekend, during which there is much less attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants