Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label to discover service monitor for prometheus. #97

Open
Q00 opened this issue Mar 11, 2024 · 0 comments · May be fixed by #106
Open

Adding label to discover service monitor for prometheus. #97

Q00 opened this issue Mar 11, 2024 · 0 comments · May be fixed by #106

Comments

@Q00
Copy link

Q00 commented Mar 11, 2024

Hi. I deployed livekit using eks and configured monitoring.
But there was an issue between Prometheus and service monitor. Prometheus can not find the service monitor.
Prometheus check a label which is 'release=prometheus' in the service monitor.
But livekit-server helm chart doesn't make this label.
Please check this helpers code in livekit-helm repository.

I edited service monitor and added the line with release=prometheus and then Prometheus can find the service monitor.

image image

Can I make the PR which add line 'release=prometheus' in service monitor labels if prometheus_port is specified in values.yml?

I used this options.

replicaCount: 2

# Suggested value for gracefully terminate the pod: 5 hours
livekit:
  port: 7880
  log_level: info
  rtc:
    ...
  redis:
    ...
  keys:
    ...
  prometheus_port: 6789
  turn:
    enabled: true
    ...
loadBalancer:
  type: disable

autoscaling:
  ...

resources:
  ...
serviceMonitor:
  create: true
  annotations: {
    "prometheus.io/scrape": "true",
    "prometheus.io/path": "/metrics",
    "prometheus.io/port": "6789"
  }
  name: "prometheus-operator"
  interval: 30s

This is my infrastructure
image

@genofire genofire linked a pull request Jul 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant