Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Nvidia unit tests related to pts < dts errors when building with ffmpeg v4.4 #247

Closed
jailuthra opened this issue Jul 7, 2021 · 1 comment
Assignees

Comments

@jailuthra
Copy link
Contributor

Quite a few NVIDIA unit tests fail when compiling with ffmpeg v4.4 in #246

The number of pts < dts warning logs also significantly increased with v4.4, might be related to #227

@jailuthra jailuthra self-assigned this Jul 7, 2021
@yondonfu yondonfu changed the title Fix failing Nvidia unit tests when building with ffmpeg v4.4 Fix failing Nvidia unit tests related to pts < dts errors when building with ffmpeg v4.4 Jul 12, 2021
@jailuthra
Copy link
Contributor Author

We've started seeing these timestamp ordering errors due to:

  1. An upstream change in how DTS (decode timestamp) is calculated by nvenc FFmpeg/FFmpeg@9ce7de9
  2. We didn't use B-frames with NVIDIA until recently ffmpeg: Enable B-frames with GPU encoding #243 - where DTS calculation actually matters.
  3. Default upstream value for B-frames was also 0 before FFmpeg/FFmpeg@a0949d0

Enabling B-frames with the new DTS calculation logic, still works for the most part - except when we have output fps: 0 i.e timestamps pass-through the transcoder verbatim.

As a temporarily solution in eae3d07 I've force-disabled B-frames when transcoding on GPU with fps: 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants