Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serwersms ability to select group_id or phone #4801

Open
lci-sinersio opened this issue May 29, 2024 · 1 comment · May be fixed by #4811
Open

serwersms ability to select group_id or phone #4801

lci-sinersio opened this issue May 29, 2024 · 1 comment · May be fixed by #4811
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor

Comments

@lci-sinersio
Copy link

📑 I have found these related issues/pull requests

Currently serwersms notifications cannot be selected between a single number and a group (group_id)

🏷️ Feature Request Type

Change to existing notification-provider, Dashboard

🔖 Feature description

ability to choose between group and telephone

✔️ Solution

ability to choose between group and phone when configuring serwersms notifications

❓ Alternatives

No response

📝 Additional Context

manually changing the phone entry to group_id in the serversms.js file allows you to use group_id instead of phone
@lci-sinersio lci-sinersio added the feature-request Request for new features to be added label May 29, 2024
@CommanderStorm
Copy link
Collaborator

This is kind of niche/uncommon notification provider. Because effort on the notification provider front does not scale well, we require a bit of help in this regard (mostly considering testing that everything still works via the screenshots we require)
Since you already found where to change a parameter, could you provide a pull request?
Our Contribution guide is here
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

@CommanderStorm CommanderStorm added area:notifications Everything related to notifications type:enhance-existing feature wants to enhance existing monitor labels May 29, 2024
@CommanderStorm CommanderStorm linked a pull request Jun 3, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the ability to use group_id as a phone number lci-sinersio/uptime-kuma
2 participants
@CommanderStorm @lci-sinersio