Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDig 5.x Support #4414

Open
1 task done
scarecr0w12 opened this issue Jan 23, 2024 · 14 comments · May be fixed by #4949
Open
1 task done

GameDig 5.x Support #4414

scarecr0w12 opened this issue Jan 23, 2024 · 14 comments · May be fixed by #4949
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor

Comments

@scarecr0w12
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

Other

🔖 Feature description

Gamedig 5.0.0-beta.0 Support

✔️ Solution

Please update package to include GameDig 5 for additional supported games, specifically PalWorld (one of the largest games to release on steam )

❓ Alternatives

None

📝 Additional Context

No response

@scarecr0w12 scarecr0w12 added the feature-request Request for new features to be added label Jan 23, 2024
@louislam
Copy link
Owner

Feel free to ping here again if they have released 5.0.0 non beta.

@scarecr0w12
Copy link
Author

Feel free to ping here again if they have released 5.0.0 non beta.

I'll be keeping an eye on it. As a work around, i should be able to change the package.json myself to include it locally, correct?

@louislam
Copy link
Owner

Yes, and run npm install --production to download the package.

@scarecr0w12
Copy link
Author

hmm i guess the new version uses import function over require now, so code change would be needed.

@CommanderStorm
Copy link
Collaborator

Not the only breaking change:

  • Almost all games ids have been changed to follow a standard, see CONTRIBUTING.md#naming.
  • Removed minecraftping (as it was deprecated and the same thing as minecraft) and minecraftpe (deprecated, which is now the same as mbe (Minecraft Bedrock Edition)).
  • Removed the games.txt file, the games definitions are now stored in-code (exported on games).

=> adding a migration with the renamings would be nessesary

That this also bumps the minimum node version to v16.
=> includes part of #3747

@CommanderStorm CommanderStorm added area:monitor Everything related to monitors type:enhance-existing feature wants to enhance existing monitor labels Jan 24, 2024
@FurkanVG
Copy link

Came here by to see that i would love this, for Palworld of course. Since there is no other way to monitor a Pal Server, i would live this.

@louislam
Copy link
Owner

Not the only breaking change:

  • Almost all games ids have been changed to follow a standard, see CONTRIBUTING.md#naming.
  • Removed minecraftping (as it was deprecated and the same thing as minecraft) and minecraftpe (deprecated, which is now the same as mbe (Minecraft Bedrock Edition)).
  • Removed the games.txt file, the games definitions are now stored in-code (exported on games).

=> adding a migration with the renamings would be nessesary

That this also bumps the minimum node version to v16. => includes part of #3747

I think it is big enough to create a new monitor type for Gamedig 5.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 28, 2024

Are you sure?

  • I think that the parts needing migration (ids changing) can be easily migrated
  • minecraftping can be migrated to minecraft
  • minecraftpe can be migrated to mbe
  • Node 14 is EOL as of 19 Oct 2021 => a long time ago => we don't need to support that.

@chakflying
Copy link
Collaborator

I think for the end-user, it doesn't make sense to have another monitor type that basically does the same thing. But some work is definitely required to make the migration smooth.

@dustyhansen
Copy link

It looks like they released v 5.0 last month. Any more thought to implementing this so we can add some of the newer games?

@CommanderStorm
Copy link
Collaborator

If you are requesting guidance on how to implment this:

feel free to ping me if you have more questions ^^

@dustyhansen
Copy link

I was just letting you guys know that 5.0 was out of beta and hoping this would get some traction since gamedig hasn't been updated in 6 months+ and is missing a few games. I'm not a developer.

@elonmir
Copy link

elonmir commented Jul 17, 2024

/bump, missing Enshrouded... added in the 5.0.X Patch of Gamedig.

@elonmir elonmir linked a pull request Jul 17, 2024 that will close this issue
7 tasks
@elonmir
Copy link

elonmir commented Jul 17, 2024

Instead of just bumping I decided to do it myself... =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants