`get_percent_bar $percentage`: Cannot validate argument on parameter 'percent' #181

aetonsi · 2023-03-24T10:59:56Z

Hi,
i'm having the error mentioned when invoking winfetch the first time after each boot. Afterwards, it works just fine.

I have created a small function to invoke winfetch with my preferred parameters:

function Show-Winfetch([switch] $Short) {
  if ($Short) {
    $params = @{
      showpkgs = ''
    }
  } else {
    $params = @{
      all       = $true
      showdisks = @('*')
      showpkgs  = @('scoop', 'choco')
    }
  }
  & winfetch @params -blink -memorystyle textbar -cpustyle textbar -diskstyle textbar -batterystyle textbar
}

Then i simply call Show-Winfetch in one of my startup scripts.
It prints this:

 lllllllllllllll   lllllllllllllll  user@COMPUTERNAME
 lllllllllllllll   lllllllllllllll  -------------
 lllllllllllllll   lllllllllllllll  OS: Windows 11 Pro N
 lllllllllllllll   lllllllllllllll  Host: HP HP Pavilion
 lllllllllllllll   lllllllllllllll  Kernel: 10.0.22621.0
 lllllllllllllll   lllllllllllllll  Motherboard: HP 87C5
 lllllllllllllll   lllllllllllllll  Uptime: 1 minute
                                    Resolution: 1536x864
 lllllllllllllll   lllllllllllllll  PS Packages: 4 Module
 lllllllllllllll   lllllllllllllll  Packages: 105 (choco)
 lllllllllllllll   lllllllllllllll  Shell: PowerShell v7.
 lllllllllllllll   lllllllllllllll  Terminal: Windows Ter
 lllllllllllllll   lllllllllllllll  Theme: Custom (System
 lllllllllllllll   lllllllllllllll  CPU: AMD Ryzen 5 4500
 lllllllllllllll   lllllllllllllll  GPU: AMD Radeon(TM) G
get_percent_bar : Cannot validate argument on parameter 'percent'. The 119 argument is greater than the maximum allowed range of 100. Supply an argument that is less than or equal to 100 and then try the command again.
At C:\tools\winfetch\winfetch.ps1:327 char:53
+         'textbar' { return "$text $(get_percent_bar $percentage)" }
+                                                     ~~~~~~~~~~~
+ CategoryInfo          : InvalidData: (:) [get_percent_bar], ParameterBindingValidationException
+ FullyQualifiedErrorId : ParameterArgumentValidationError,get_percent_bar
                                    CPU Usage: 299 proces
                                    Memory: 7.67 GiB / 19
                                    Disk (C:): 309 GiB /
                                    Disk (K:): 3 GiB / 15
                                    Disk (L:): 317 GiB /
                                    Battery: Discharging,
                                    Locale: Italy - Engli
                                    Weather: 6°C - Overca
                                    Local IP: 192.168.178
                                    Public IP: 99.17.56.1

The output is truncated like that because i am running the script inside a Windows Terminal split pane ($Host.UI.RawUI.WindowSize.Width = 58, $Host.UI.RawUI.WindowSize.Height = 30)

thank you for your time

The text was updated successfully, but these errors were encountered:

rashil2000 · 2023-03-24T11:26:21Z

Can you try isolating which segment is causing the error? I think it's CPU usage, but please confirm.

aetonsi · 2023-03-24T11:30:35Z

how do i do that, exactly? i'll have to reboot the pc for each attempt so i have to be sure to make the correct edits...

rashil2000 · 2023-03-24T11:32:52Z

You can edit the config file located at ~/.config/winfetch/config.ps1

And you don't need to reboot every time - you can just run the script directly after editing the config file.

aetonsi · 2023-04-03T08:00:55Z

Hi, i've not been able to reproduce the issue again, i sincerely don't know what caused it, sorry

aetonsi · 2023-04-18T21:02:16Z

@rashil2000 it happened again but i have no idea why, i cannot reproduce it regularly😞 ... it's always after the GPU line and when running in a small window, though:

 lllllllllllllll   lllllllllllllll  user@computer
 lllllllllllllll   lllllllllllllll  -------------
 lllllllllllllll   lllllllllllllll  OS: Windows 11 Pro N
 lllllllllllllll   lllllllllllllll  Host: HP HP Pavilion
 lllllllllllllll   lllllllllllllll  Kernel: 10.0.22621.0
 lllllllllllllll   lllllllllllllll  Motherboard: HP 87C5
 lllllllllllllll   lllllllllllllll  Uptime: 2 minutes
                                    Resolution: 1536x864
 lllllllllllllll   lllllllllllllll  PS Packages: 5 Module
 lllllllllllllll   lllllllllllllll  Packages: 110 (choco)
 lllllllllllllll   lllllllllllllll  Shell: PowerShell v7.
 lllllllllllllll   lllllllllllllll  Terminal: Windows Ter
 lllllllllllllll   lllllllllllllll  Theme: Custom (System
 lllllllllllllll   lllllllllllllll  CPU: AMD Ryzen 5 4500
 lllllllllllllll   lllllllllllllll  GPU: AMD Radeon(TM) G
get_percent_bar : Cannot validate argument on parameter 'percent'. The 114 argument is greater than the maximum allowed range of 100. Supply an argument that is less than or equal to 100 and then try the command again.
At C:\tools\winfetch\winfetch.ps1:327 char:53
+         'textbar' { return "$text $(get_percent_bar $percentage)" }
+                                                     ~~~~~~~~~~~
+ CategoryInfo          : InvalidData: (:) [get_percent_bar], ParameterBindingValidationException
+ FullyQualifiedErrorId : ParameterArgumentValidationError,get_percent_bar
                                    CPU Usage: 316 proces
                                    Memory: 9.21 GiB / 19
                                    Disk (C:): 312 GiB /
                                    Disk (K:): 0 GiB / 15
                                    Disk (L:): 320 GiB /
                                    Battery: Discharging,
                                    Locale: Italy - Engli
                                    Weather: 9°C - Clear
                                    Local IP: 192.168.xxx
                                    Public IP: 2.36.xxx.x

what can i do to debug?

rashil2000 · 2023-05-26T10:17:36Z

You can edit the config file located at ~/.config/winfetch/config.ps1

Make a backup of this file somewhere. Then edit it to include just the following text:

@(
    cpu_usage
)

and now try to repro the issue

aetonsi · 2023-06-01T09:59:37Z

Hi, i think you meant "cpu_usage" (with quotes). This is winfetch output:

>winfetch

 lllllllllllllll   lllllllllllllll  CPU Usage: 18% (340 processes)
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll

 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll
 lllllllllllllll   lllllllllllllll

So, no error.... it doesn't always pop up anyways, only a few times, sporadically

rashil2000 · 2023-06-02T20:07:13Z

@Carterpersall any idea why the total comes up more than 100 here sometimes?

Carterpersall · 2023-06-09T13:29:55Z

@Carterpersall any idea why the total comes up more than 100 here sometimes?

Sorry about the delay, I don’t have a lot of time in the summer to code.
I’m not really sure why it is doing that, but I do have two theories:

The current implementation treats parent and child processes the same, which might lead to double counting the CPU usage of some programs. This does depend on parent processes also including the CPU time of the child processes, which may or may not be the case.
The method might occasionally return garbage for some reason. I don’t like the idea of blaming this issue on Microsoft, but it is possible. It could be caused by the counter they use (if they use one) not having a high enough delay between the first and second read, which would sometimes create a garbage reading. It would also explain why it can happen on the first usage of it but not subsequent ones. I would need to look into the source of the System.Diagnostics.Process class (if available) to figure out if that could be the case.

As for a solution, I can see two possible avenues for now:

Check if the CPU usage is over 100%, and if it is, set it to 100% to avoid the error.
If CPU usage is over 100%, try executing the function again. If it fails again, either fail gracefully (print an error message) or set it to 100%.

Carterpersall · 2023-06-20T19:38:58Z

Here’s what I’ve found after looking into how [System.Diagnostics.Process]::GetProcesses() works:

winfetch.ps1#L743: [System.Diagnostics.Process]::GetProcesses()
- dotnet/runtime/.../Process.cs#L1081: public static Process[] GetProcesses() {
- dotnet/runtime/.../Process.cs#L1083: GetProcesses(".");
  - dotnet/runtime/.../Process.cs#L1096: public static Process[] GetProcesses(string machineName) {
  - dotnet/runtime/.../Process.cs#L1099: ProcessManager.GetProcessInfos(processNameFilter: null, machineName);
    - dotnet/runtime/.../ProcessManager.Win32.cs#L278: internal static unsafe ProcessInfo[] GetProcessInfos(int? processIdFilter = null, string? processNameFilter = null) {
    - dotnet/runtime/.../ProcessManager.Win32.cs#L290: Interop.NtDll.NtQuerySystemInformation(Interop.NtDll.SystemProcessInformation, bufferPtr, bufferSize, &actualSize);
      - reactos/ntoskrnl/ex/sysinfo.c#L2929: NtQuerySystemInformation(...) {
      - reactos/ntoskrnl/ex/sysinfo.c#L2985: CallQS[SystemInformationClass].Query(SystemInformation, SystemInformationLength, &CapturedResultLength);
        
        reactos/ntoskrnl/ex/sysinfo.c#L877: QSI_DEF(SystemProcessInformation) {
        
        reactos/ntoskrnl/ex/sysinfo.c#L1070: KeQueryRuntimeProcess(&Process->Pcb, &TotalUser);
        
        reactos/ntoskrnl/ke/procobj.c#L860: KeQueryRuntimeProcess(IN PKPROCESS Process, OUT PULONG UserTime) {
        
        Iterates over each thread of each process and sets UserTime to the total User-Level CPU Time and returns KernelTime, which is the total Kernel-Level CPU Time

It's possible that the source of the bug is that we are using each process's start time on a CPU time that is measured per-thread, which have their own individual start times. I threw together an implementation of info_cpu_usage that uses every thread instead of each process, but it seems to be about 2.5x slower. It also returns different results, but it may be more accurate due to the "more correct" usage of the CPU times. More testing is needed to confirm.

aetonsi · 2023-06-21T09:54:17Z

Well if 2.5x means a few milliseconds more, i'd say that's acceptable? i did measure what the current function took to complete and it was less than 15ms, so 2.5x would still be negligible IMHO

aetonsi closed this as completed Apr 3, 2023

aetonsi reopened this Apr 18, 2023

aetonsi mentioned this issue Sep 25, 2023

clist deprecated in chocolatey v2 #189

Closed

Lil-Dank mentioned this issue Nov 13, 2023

Default Values for exceeding range 0-100 in get_percent_bar #203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`get_percent_bar $percentage`: Cannot validate argument on parameter 'percent' #181

`get_percent_bar $percentage`: Cannot validate argument on parameter 'percent' #181

aetonsi commented Mar 24, 2023

rashil2000 commented Mar 24, 2023

aetonsi commented Mar 24, 2023

rashil2000 commented Mar 24, 2023

aetonsi commented Apr 3, 2023

aetonsi commented Apr 18, 2023

rashil2000 commented May 26, 2023

aetonsi commented Jun 1, 2023

rashil2000 commented Jun 2, 2023

Carterpersall commented Jun 9, 2023

Carterpersall commented Jun 20, 2023 •

edited

Loading

aetonsi commented Jun 21, 2023

get_percent_bar $percentage: Cannot validate argument on parameter 'percent' #181

get_percent_bar $percentage: Cannot validate argument on parameter 'percent' #181

Comments

aetonsi commented Mar 24, 2023

rashil2000 commented Mar 24, 2023

aetonsi commented Mar 24, 2023

rashil2000 commented Mar 24, 2023

aetonsi commented Apr 3, 2023

aetonsi commented Apr 18, 2023

rashil2000 commented May 26, 2023

aetonsi commented Jun 1, 2023

rashil2000 commented Jun 2, 2023

Carterpersall commented Jun 9, 2023

Carterpersall commented Jun 20, 2023 • edited Loading

aetonsi commented Jun 21, 2023

`get_percent_bar $percentage`: Cannot validate argument on parameter 'percent' #181

`get_percent_bar $percentage`: Cannot validate argument on parameter 'percent' #181

Carterpersall commented Jun 20, 2023 •

edited

Loading