-
|
Following is a very oddness error message which i consider it useful to mention here, you can reproduce it use following sample app strange_error branch. https://github.com/one-in-ten-thousand/production_line_report/tree/strange_error Basically, i just want to use a component for common purpose, this is source code. as you can see, it just a each loop on records, with, pass the different part into it. Strange things start happen here, I use it like this in two different page. class Admin::Manufactories::IndexPage < MainLayout
needs manufactories : ManufactoryQuery
def content
mount RecordList,
records: manufactories, # <= passed manufactories Here
show: Show,
edit: Edit,
delete: Delete
end
endclass Admin::Manufactories::ShowPage < MainLayout
needs workshops : WorkshopQuery
def content
mount RecordList,
records: workshops, # <= passed workshops Here.
show: ::Admin::Workshops::Show,
edit: ::Admin::Workshops::Edit,
delete: ::Admin::Workshops::Delete
end
endWhen i try to build on it, i get following error message. error trace, click to openThe really wired things is, The fix is simple, split above components to two, all works fine. class ManufactoryList < BaseComponent
needs records : ManufactoryQuery
needs show : Admin::Manufactories::Show.class
needs edit : Admin::Manufactories::Edit.class
needs delete : Admin::Manufactories::Delete.classclass WorkshopList < BaseComponent
needs records : WorkshopQuery
needs show : Admin::Workshops::Show.class
needs edit : Admin::Workshops::Edit.class
needs delete : Admin::Workshops::Delete.classSo, any idea? Thanks. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 5 replies
-
|
That is a strange error. It seems to suggest that you were calling In any case, I think splitting them is a much better option in the end 👍 |
Beta Was this translation helpful? Give feedback.
-
|
Hi, i am dig deeper this issue again, still could not figure out why this strange issue happen. probably previous description not clear enough, let me reduce it. there is a component like following: class RecordList < BaseComponent
needs records : ManufactoryQuery
needs show123 : Admin::Manufactories::Show.class | Admin::Workshops::Show.class
def render
tbody do
records.each do |record|
tr do
pp! show123
pp! show123.with(record)
text "hello"
end
end
end
end
endThen use it in another page, like following: needs manufactories : ManufactoryQuery
mount RecordList,
records: manufactories,
show123: ::Admin::Manufactories::ShowThen i always get compile-time error like following: But if comment So i try change to ``pp! show123.as(Admin::Manufactories::Show.class).with(record) Another workaround is, remove the union type in component into: I consider the Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Crystal tends to do some strange stuff with unions. I think you might need to go a little more generic with this one like needs show123 : Lucky::Action.class
def render
records.each do |record|
case show123
when Admin::Manufactories::Show.class, Admin::Workshops::Show.class
show123.with(record)
else
raise or render something here
end
end
endThis is untested, so I don't know if it'll actually work. Here's the Lines 331 to 360 in dd21f8b |
Beta Was this translation helpful? Give feedback.
-
I guess what you said is common superclass of both, it should be class RecordList < BaseComponent
needs records : ManufactoryQuery
needs show123 : BrowserAction.class
def render
records.each do |record|
case show123
when Admin::Manufactories::Show.class, Admin::Workshops::Show.class
show123.with(record)
else
# raise or render something here
end
end
end
endI have an explain for this issue: def self.with(
# required path variables
{% for param in path_params %}
{{ param.gsub(/:/, "").id }},
{% end %}
......
anchor : String? = nil
) : Lucky::RouteHelper
......
endthe if macro expand correct, it should be: def with(manufactory_id, anchor : String | ::Nil) : Lucky::RouteHelper but, if use component with union, the method signature i guess like following (the above macro expand is ignored) def with(anchor : String | ::Nil) : Lucky::RouteHelper in other word, macro expand failed on union type, i try add macro debug to debug, but without get the clear clue, i guess the issue happen when get the path/url of union model object used in Anyway, those code is complex, and hard to figure out. |
Beta Was this translation helpful? Give feedback.
-
Did you try using Is the error message the same? What if you do case show123
when Admin::Manufactories::Show.class
show123.with(manufactory_id: record.id)
when Admin::Workshops::Show.class
show123.with(workship_id: record.id)
else
# raise or render something here
end |
Beta Was this translation helpful? Give feedback.
-
Tried, not work.
Yes. following code not work. class RecordList < BaseComponent
needs records : ManufactoryQuery
needs show123 : Lucky::Action.class
def render
records.each do |record|
case show123
when Admin::Manufactories::Show.class
show123.with(manufactory_id: record.id)
else
# raise or render something here
end
end
end
endget error: Change BTW: as hack still work. show123.as(Admin::Manufactories::Show.class).with(manufactory_id: record.id) I used to believe that "case...when"（translate into: Admin::Manufactories::Show.class === show123 ) and ".as(...)" did the same thing, but i am wrong. EDIT: finally, i get your point, make my code works! following is the complete code, and i tried mount this component in different places with different type record, no any compile-time error. class RecordList < BaseComponent
needs records : ManufactoryQuery | WorkshopQuery
needs show : Lucky::Action.class
needs edit : Lucky::Action.class
needs delete : Lucky::Action.class
def render
s = show
e = edit
d = delete
table class: "highlight centered" do
thead do
tr do
th "ID"
th "名称"
th "创建时间"
th colspan: 2
end
end
tbody do
records.each do |record|
tr do
td record.id
td do
case s
when Admin::Manufactories::Show.class
link record.as(Manufactory).name, s.with(manufactory_id: record.id)
when Admin::Workshops::Show.class
link record.as(Workshop).name, s.with(workshop_id: record.id)
end
end
td record.creation_date
td do
case e
when Admin::Manufactories::Show.class
link "编辑", e.with(manufactory_id: record.id)
when Admin::Workshops::Show.class
link "编辑", e.with(workshop_id: record.id)
end
end
td do
case d
when Admin::Manufactories::Show.class
link "删除", d.with(manufactory_id: record.id), data_confirm: "确认？"
when Admin::Workshops::Show.class
link "删除", d.with(workshop_id: record.id), data_confirm: "确认？"
end
end
end
end
end
end
end
end
The point is:
Error: undefined method 'name' for Report (compile-time type is BaseModel+) Because type promotion make record type become to abstruct class
|
Beta Was this translation helpful? Give feedback.
-
|
Glad you got it figured out! |
Beta Was this translation helpful? Give feedback.
That is a strange error. It seems to suggest that you were calling
Admin::Companies::Create.with(record)somewhere... Maybe a form?In any case, I think splitting them is a much better option in the end 👍