Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if Actions are the cause of long compilcation times #1783

Open
jwoertink opened this issue Mar 6, 2023 · 2 comments
Open

Investigate if Actions are the cause of long compilcation times #1783

jwoertink opened this issue Mar 6, 2023 · 2 comments
Labels
needs investigation A possible bug / better docs needed. Investigate further

Comments

@jwoertink
Copy link
Member

For our app we compile the main app binary, and a separate mosquito worker binary. Both binaries require the same app code with the exception that the worker binary doesn't require any actions.

This is the difference in compilation time
image

I think to further investigate this, we just need to benchmark compiling an app, then compiling a separate app that doesn't use Actions, and see if there's truly a difference, or is it that we're doing something with our app?

My app has 28 action classes... Though it's a decent size, that's not really that many.

@jwoertink jwoertink added the needs investigation A possible bug / better docs needed. Investigate further label Mar 6, 2023
@jwoertink
Copy link
Member Author

toddsundsted/ktistec@9acf0c3

This is an interesting find. According to this comment, it's possible that blocks could be a source here. I'm not sure if this helps us here or not, but it's worth adding to the investigation.

@jwoertink
Copy link
Member Author

Working on some app updates, we've added 257 new actions to our app, and the compilation time is roughly the exact same... So now the question is, why does our worker code build SO much faster if it's not the actions causing the increased compilation time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation A possible bug / better docs needed. Investigate further
Projects
None yet
Development

No branches or pull requests

1 participant