Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the default environment cache key have the current date? #50

Open
zacharyburnett opened this issue Apr 27, 2023 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@zacharyburnett
Copy link

I would think the default cache key should be tied to the date in some way, so as to prevent the cache from becoming outdated. if this is an intentional design decision I can construct my own cache key

@jonashaag
Copy link
Collaborator

The cache is invalidated by the environment file.

@zacharyburnett
Copy link
Author

The cache is invalidated by the environment file.

Indeed, if the file changes, but if creating an environment from the same file at a later date, then if any packages had new releases in the meantime then they would be outdated in the cache; is this intentional?

@jonashaag
Copy link
Collaborator

I see, in that case the cache will be invalidated only when GitHub deletes it (I think after 7 days?). I wonder if there is any good invalidation policy based on date that we can make a default.

@pavelzw
Copy link
Member

pavelzw commented Apr 28, 2023

There are cases where you don't want to tie the cache validity to the date, for example when using lockfiles as your environment file.

I'm not sure which option is better, though. Adding some kind of check if we use a lockfile or a regular environment file would lead to further complexity of the action, something that I would like to prevent if possible.

I think after 7 days?

After 7 days not being used or after 7 days in general?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants