Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect semi-transparent tile rendering at terrain tile borders #4991

Open
NathanMOlson opened this issue Nov 5, 2024 · 3 comments
Open
Labels

Comments

@NathanMOlson
Copy link
Contributor

NathanMOlson commented Nov 5, 2024

maplibre-gl-js version: 4.7.1, 5.0.0-pre.5

browser: Chrome

Steps to Trigger Behavior

  1. Create a map with semi-transparent raster tiles
  2. Enable terrain (may be zero-elevation tiles)
  3. Pitch the map

Link to Demonstration

Raster tiles:
https://jsfiddle.net/gbc64wm5/

Background layer:
https://jsfiddle.net/hb5e1rj6/

Expected Behavior

Rendered image is seamless across the border between terrain tiles.
image

Actual Behavior

It looks like a "cliff" at the edge of the terrain tile is being rendered in the imagery.

image
@NathanMOlson
Copy link
Contributor Author

Changing getMeshFrameDelta(zoom) to { return 0; } seems to solve this problem, but I don't know what that might be breaking...

@NathanMOlson
Copy link
Contributor Author

Changing getMeshFrameDelta(zoom) to { return 0; } seems to solve this problem, but I don't know what that might be breaking...

It looks like this issue was introduced by #1710. Setting getMeshFrameDelta(zoom) to 0 would re-introduce #1602 :(

@ibesora
Copy link
Collaborator

ibesora commented Nov 6, 2024

We might need to change the approach used to remove tile seams by using a two-pass rendering with stencil enabled

@ibesora ibesora added the terrain label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants