Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FoV has a hardcoded value in FlyTo #5078

Open
AbelVM opened this issue Nov 20, 2024 · 3 comments
Open

FoV has a hardcoded value in FlyTo #5078

AbelVM opened this issue Nov 20, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers PR is more than welcomed Extra attention is needed

Comments

@AbelVM
Copy link

AbelVM commented Nov 20, 2024

Now that the FoV can be arbitrarily set up by the user, we should change the code block at https://github.com/maplibre/maplibre-gl-js/blob/main/src/ui/camera.ts#L1471-L1475 to reflect that, instead of being fixed to 53º.

@HarelM
Copy link
Collaborator

HarelM commented Nov 20, 2024

Any chance you could open a PR for this?

@HarelM HarelM added enhancement New feature or request good first issue Good for newcomers PR is more than welcomed Extra attention is needed labels Nov 20, 2024
@AbelVM
Copy link
Author

AbelVM commented Nov 20, 2024

Based on https://vanwijk.win.tue.nl/zoompan.pdf , looks like the issue is related to the comment, not the code. But I can't be sure as this function is a bit of a rabbit hole for me right now.

I'm digging into it to take #116 back into life with the new tiles logic

@HarelM
Copy link
Collaborator

HarelM commented Nov 20, 2024

Since the addition of editing FoV was just added recently, I'll bet that the comment is no longer up to date...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants