Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map ends up with roll when rollEnabled=false #5083

Open
NathanMOlson opened this issue Nov 20, 2024 · 2 comments · May be fixed by #5092
Open

Map ends up with roll when rollEnabled=false #5083

NathanMOlson opened this issue Nov 20, 2024 · 2 comments · May be fixed by #5092
Assignees
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed

Comments

@NathanMOlson
Copy link
Contributor

maplibre-gl-js version: 5.0.0-pre.3, 5.0.0-pre.7

browser: Chrome

Steps to Trigger Behavior

  1. Pitch the map to approximately pitch=0.
  2. "Throw" the map. (Give it a quick rotation so that it continues rotating when you let go of the mouse button).
  3. Before the map stops rotating, interrupt the motion by clicking on the map again
  4. Pitch the map. You will see that the map is now rolled.

Demonstration

unwanted_roll.mp4

Expected Behavior

When rollEnabled=false, no user mouse input causes the map to roll.

Actual Behavior

When rollEnabled=false, the map ends up rolled when rotations near pitch = 0 are interrupted.

@HarelM HarelM added bug Something isn't working PR is more than welcomed Extra attention is needed labels Nov 20, 2024
@HarelM
Copy link
Collaborator

HarelM commented Nov 20, 2024

@NathanMOlson should I be assigning this issue to you?

@NathanMOlson
Copy link
Contributor Author

@NathanMOlson should I be assigning this issue to you?

Sure, I introduced this and I know how to fix it.

NathanMOlson added a commit to NathanMOlson/maplibre-gl-js that referenced this issue Nov 21, 2024
@NathanMOlson NathanMOlson linked a pull request Nov 21, 2024 that will close this issue
5 tasks
NathanMOlson added a commit to NathanMOlson/maplibre-gl-js that referenced this issue Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants