You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I must either document that feature or remove it entirely (if I'm considering it a bug). It's a serious implication on the whole system, 'cause talents are created dynamically, thus they will be destroyed dinamically as well. On the other side, it's quite unsound to remove behavior from the decorated objects, despite the dynamic feel of talent acquisition/learning and releasing. The interface is affected and clients relying on that won't expect undefined behavior. Some careful design choice is needed here, it won't be possible to go back and break the API. Hence, it demands some time, review, tradeoffs and proper attention.
The text was updated successfully, but these errors were encountered:
State explicitly where (i.e, on decorated objects) and which talents are removed/released. The removal/releasing will affect only the said decorated object, so things here are also fine-grained.
Cover on test suite that bug.
There's some major problem regarding the Lua version 5.1. Such version (either official or LuaJIT) doesn't collect/release unreachable talent references. See the following Travis-CI build https://travis-ci.org/marcoonroad/talents/builds/270607083 🔗 .
Therefore, the explicit talent releasing won't break the API on old Lua versions.
I must either document that feature or remove it entirely (if I'm considering it a bug). It's a serious implication on the whole system, 'cause talents are created dynamically, thus they will be destroyed dinamically as well. On the other side, it's quite unsound to remove behavior from the decorated objects, despite the dynamic feel of talent acquisition/learning and releasing. The interface is affected and clients relying on that won't expect undefined behavior. Some careful design choice is needed here, it won't be possible to go back and break the API. Hence, it demands some time, review, tradeoffs and proper attention.
The text was updated successfully, but these errors were encountered: