Issue with number of submissions

[cjhudson78]

Describe the bug
A client of ours using the plugin described that it was failing to bring through the correct number of submissions when used with an assignment activity.

If there were 20 submissions, when the report was run, at the bottom of the page it would say, for example, 'showing 1-10 of 13 submissions'. If you enter the grader report, click into 'grade' and click through a few entries, then return to the report, it would increase slightly and say 'showing 10-10 of 16 submissions'.

To Reproduce
Steps to reproduce the behavior:

1. Create an assignment activity with a significant number of submissions
2. Once all of the submissions have been gathered, access the marking guide breakdown report
3. As the bottom of the page, it should say 'showing 1-10 of X submissions', which is lower than the genuine number of submissions
4. Exit and go to 'View all submissions'
5. Click 'grade' in one of them and use the change user arrows to toggle through a few without changing anything, but having to click 'save and continue' regardless
6. Exit and return the the marking guide breakdown report
7. The number of submissions at the bottom should have increased by a few more submissions

Expected behavior
The total number of submissions returned by the report should match the number received.

Screenshots

1 - showing total number of submissions

2 - when accessing the report initially

3 - into the grading screen to click through some submissions

4 - returning to the report afterwards

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Chrome
• Version: 110.0.5481.78

Additional context
Add any other context about the problem here.

[marcusgreen]

Thank you for including so much detail. As an admin account can you add this to the URL of your moodle
/admin/settings.php?section=reportadvancedgrading.

Temporarily uncheck the item

Enable javascript layout

Then test if the problem still shows up. That setting is not mentioned in the documentation.

[marcusgreen]

What version of Moodle are you using (not that it should make any difference)

[cjhudson78]

Hi Marcus,

This site is on 3.11

I disabled that and purged caches but the problem persists.

[marcusgreen]

It will only show records for which there is a grading record. Can you confirm that the records shown match those for which there is a grading record.

[cjhudson78]

I dip-checked a few who are showing, their grades in the report match what's in the submission grades.

The only curiosity I noticed is that the gradebook itself contains no grades whatsoever for any of the 26 participants.

[marcusgreen]

So it does shows the records of submissions that have been marked but also some that have not been marked?

I suspect that when you view a grade in the grading interface an empty record is created (I might be wrong).

The only curiosity I noticed is that the gradebook itself contains no grades whatsoever for any of the 26 participants.

Does that match my empty record theory?

This report from Brickfield (the accessibility people) covers a similar area

https://github.com/brickfield/moodle-gradereport_rubrics

That doesn't seem to support blind marking, though last week I created a branch of my own and have some experimental code to do blind marking. It would be interesting to compare what that shows with what my report shows.

[cjhudson78]

It's presently showing 17 entries in the report, but 26 have been marked and have grades - there's no apparent correlation between what it's showing and the empty gradebook.

[marcusgreen]

Can you confirm that 9 marked assignments are not showing in that report? Do the missing ones have a difference in not having a comment/Entry in a feedback field (wild guesswork here).

The plugin comes with some (fairly) human readable automated tests, but they don't cover every permutation. You can see them here

https://github.com/marcusgreen/moodle-report_advancedgrading/tree/main/tests/behat

If it were possible I would be happy to take a look at the course to see if I can spot anything that might be causing this.

[cjhudson78]

Hi Marcus,

9 of the 11 that are not showing have grades showing in the submissions screen. (The other two weren't graded).

It might be good to show you on a call so you can see any other settings that might be off.

[marcusgreen]

You can email me at marcusavgreen at gmail.com, send me some suggested times.

[lforsgren]

I have a similar issue. Using the rubric - no assignments are uploaded - but - 28 learners were graded. All 28 "download" with the export component tool, but with this tool/plugin, only 9 entries appear. I detect no difference from grade entries that appear vs. ones that do not. Using Moodle 3.9.9 (Build: 20210729) I also disabled javascript layout, but no change. This happens in every course as far as I can tell (only a portion of graded entries are exported).

[marcusgreen]

My advice would be similar to as above with the addition that if you are in a position to give me teacher access to one of your courses then I may be able to work out what is going on more quickly. I didn't understand your comment that no assignments have been uploaded, but 28 learners were graded.

[lforsgren]

Thank you for the offer - I will email directly.
In Moodle, an assignment can have a rubric for grading without any attachment uploaded. That's the case for this assignment. It's also "hidden" - we don't want students to see the grading - it's for institutional assessment rather than a grade.

Anyhow, I'll reach out to you directly.

[moodleulpgc]

Hi, I can confirm that the number of students listed in the report do not match the number or marked students.

If you have an Assignment without anything to submit by the students (just to assess offline work), without any submission plugin enabled, we do NOT see any student listed in de report_advancedgrades table, even when there are several graded and the grades are visible within assignment and gradebook.

[marcusgreen]

I will look into running the report where students do not have to submit anything. I did not test that scenario during development.

[ghost]

Hey @marcusgreen - I've been able to replicate this issue, but this time in a different site. I'm happy to provide any pertinent information but just wanted to check if there have been any developments?

[marcusgreen]

There have been no further developments. I have spoken to a few people about using it with the concern that this has not been resolved. I would be very interested in more details when you were able to duplicate it.

[ghost]

Thanks for letting me know so quickly! I'll fire off a meeting invite to your email, if that's okay, since it'll likely be far easier to show you than to type it all out.

[danmarsden]

I think this may have actually been fixed by the patch in #19 - prior to that patch, we were seeing some missing data in the reports.

[marcusgreen]

Thanks Dan, I think you are right. I plan to look at the issues reported in this repo today, particularly this one.
#15
And I have also thought that if someone deselects all the name options (not a good idea but people might), the output will be broken, so will look at putting in a default if nothing is selected.