Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Region allowMissingEl #3263

Open
paulfalgout opened this issue Nov 17, 2016 · 3 comments
Open

Deprecate Region allowMissingEl #3263

paulfalgout opened this issue Nov 17, 2016 · 3 comments
Milestone

Comments

@paulfalgout
Copy link
Member

#1984

allowMissingEl is currently missing from the v3 documentation.

However I think we should deprecate it. Maybe for removal in v5? I don't like it much as a solution. I also personally think future versions of regions should not accept selectors, but expect DOM elements passed in, and the view's should probably be doing the DOM querying prior to creation. But that's for another issue.

In any case, I don't think supporting allowMissingEl will make sense in the long term. In the meantime I might suggest using the ui hash to define region selectors and checking for their existence prior to showing, if this is an issue.

This to me handles an edge case, but makes the code less malleable.

@blikblum
Copy link
Collaborator

@paulfalgout do you think it can be removed in v4?

@paulfalgout
Copy link
Member Author

I think it's a little early to remove it. There's a potential use case for it now as there's some odd places where errors could occur if you're rendering templates without every region available.

However if we can move to optimistic region instantiation or something like that, the flag will be unnecessary, or at least the predominate wisdom should be to only show a view in a region that exists 😸

@paulfalgout paulfalgout added this to the v4.x milestone Apr 29, 2019
@paulfalgout
Copy link
Member Author

For removal in v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants