Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File structure #43

Open
solkaz opened this issue Jan 13, 2017 · 4 comments
Open

File structure #43

solkaz opened this issue Jan 13, 2017 · 4 comments
Labels
Milestone

Comments

@solkaz
Copy link
Contributor

solkaz commented Jan 13, 2017

The file structure is a mess, as we have all the test files with the components and don't separate the components out. I think it would be beneficial to organize the files a little, so that 1) newcomers won't be overwhelmed by all the files in src/ and 2) to allow for better clarity as to how things are connected

We could implement something like such:
project_home/

  • tests/
  • src/
    • components/
    • regular .js files
@Hopding
Copy link
Contributor

Hopding commented Jan 13, 2017

Creating a tests folder may be useful. I placed the tests alongside the components because I think it makes things easier to find that way, as the test is always immediately beside the component. That is also how tests are structured in Go (and thus the skilldirectory API). I'm not actively opposed to having a tests/ folder, but I personally prefer them as they are.

Note that if we do go that route, the test folder would need to be called __tests__ in order for jest to use it correctly.

I definitely support adding a components folder.

@dane-johnson
Copy link
Contributor

I am in support of this refactoring too. I think we really need to be sure all our ducks are in a row before we do this, or we could wind up needing to do one hell of a merge.

@thebho
Copy link
Member

thebho commented Jan 17, 2017

We can halt work on the UI for an afternoon to rework the project structure. Make sure everyone is happy and then continue.

@solkaz
Copy link
Contributor Author

solkaz commented Jan 18, 2017

If we do take an afternoon to do so, we should also make sure we're compliant with eslint at the same time.

@thebho thebho added the ready label Feb 6, 2017
@thebho thebho added this to the 0.2 milestone Feb 6, 2017
@Hopding Hopding added in progress and removed ready labels Feb 16, 2017
@Hopding Hopding self-assigned this Feb 16, 2017
@Hopding Hopding added ready and removed in progress labels Feb 17, 2017
@Hopding Hopding removed their assignment Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants