Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified links to github and orcid don't work #20017

Open
robertfromont opened this issue Nov 7, 2022 · 6 comments
Open

Verified links to github and orcid don't work #20017

robertfromont opened this issue Nov 7, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@robertfromont
Copy link

Steps to reproduce the problem

  1. Add link to Mastodon profile on GitHub profile or orcid.org profile
  2. Add link to GitHub profile or orcid.org profile back to Mastodon profile
  3. Inspect source of Github/OrcID page to ensure they have rel="me" - they do

Expected behaviour

The external profile links should appear as verified in Mastodon

Actual behaviour

They appear as regular (non verified) links

Detailed description

I suspect that this is because both GitHub and OrcID add other stuff to the rel attribute:

  • on my GithHub profile, it's rel="nofollow me"
  • on by OrcID profile, it's rel="me nofollow noopener noreferrer"

I understand that "nofollow" means 'the link is not endorsed', but although it's not endorsed by GitHub and OrcID, it is endorsed by me, that's why I put it in my profile!

Specifications

Seems to be Mastodon v3.5.3.

@robertfromont robertfromont added the bug Something isn't working label Nov 7, 2022
@ClearlyClaire
Copy link
Contributor

It only needs me to be in the rel attribute, it does not need to be the only one.

However, the link is only verified once shortly after you edit your profile, so the link needs to be there before you save your profile. This is badly explained and commonly confuses people, so we will work on improving that.

@robertfromont
Copy link
Author

Ok! I can see that deleting and re-adding it works.
Sorry and thanks!

@robertfromont
Copy link
Author

...spoke too soon? It works for GitHub profiles, but not OrcID profiles, e.g. mine is:
https://orcid.org/0000-0001-5271-5487

...which includes:

<a _ngcontent-ojk-c128="" target="_blank" 
   rel="me nofollow noopener noreferrer" 
   href="https://scholar.social/@robertfromont">Mastodon</a>

Is this because it's not included in the first http request maybe? (The OrcID profile seems to be an Angular app)

@robertfromont robertfromont reopened this Nov 12, 2022
@IzzySoft
Copy link

IzzySoft commented Nov 20, 2022

Same with Gitea instances btw which also add the "nofollow". Reproducible here with Mastodon 4.x.

<a rel="me nofollow" href="https://floss.social/@IzzyOnDroid">Mastodon</a>

is in my profile at https://codeberg.org/izzy and does not verify (waited for 3 days now).

EDIT: Removing and re-adding that link to my account on floss.social verified the link successfully for me.

@robertfromont
Copy link
Author

Alas, removing and re-adding my ORCID still doesn't verify in v4.0.2 on scholar.social

@nemobis
Copy link
Contributor

nemobis commented Nov 25, 2022

This is an issue with ORCID: ORCID/ORCID-Source#6668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants