Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin doesn't work with napari>=0.5.0 #287

Closed
zoccoler opened this issue Sep 26, 2024 · 9 comments
Closed

Plugin doesn't work with napari>=0.5.0 #287

zoccoler opened this issue Sep 26, 2024 · 9 comments
Labels
New feature New feature or request

Comments

@zoccoler
Copy link
Contributor

zoccoler commented Sep 26, 2024

Hi all,

I was trying to update some environments with the latest napari version and where this plugin is installed.
However, that is not possible because this plugin currently requires napari<0.5 as stated here. Any plans to have it functional with latest napari versions?

@dstansby
Copy link
Member

I don't have time to add support at the moment, but PRs welcome! #274 is my incomplete effort at fixing this, which might be helpful for anyone who wants to pick it up.

@dstansby dstansby added the New feature New feature or request label Sep 29, 2024
@samcunliffe
Copy link
Collaborator

Looks like you had it most of the way!
Just a difference in a 2D scatter test?

@jni
Copy link

jni commented Oct 1, 2024

LOL man it is so weird when things coincide, I was literally just popping in to see what the deal was, and I find a whole bunch of folks requesting the same thing at the same time. 😂

Can we add a pytest.mark.xfail to the test and get on with our lives? 😂 🙏

@dstansby
Copy link
Member

dstansby commented Oct 1, 2024

I'd rather not just ignore the test in case it's a real issue

@jni
Copy link

jni commented Oct 1, 2024

Haha sure I just know from experience that many test failures in big upgrades can be essentially spurious. But your point is definitely taken! 😊

@dstansby
Copy link
Member

dstansby commented Oct 1, 2024

Thanks to @samcunliffe for fixing this - I will try and get a new release out in the next few days, and will keep this open as a reminder to me :)

@dstansby
Copy link
Member

dstansby commented Oct 8, 2024

🚢 released!

@dstansby dstansby closed this as completed Oct 8, 2024
@jni
Copy link

jni commented Oct 8, 2024

Thank you @dstansby and @samcunliffe!!! ❤️ 🙏

@zoccoler
Copy link
Contributor Author

zoccoler commented Oct 9, 2024

Thank you guys! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants