Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Jazzy and Pre-Jazzy builds have diverged #1989

Closed
evan-palmer opened this issue Sep 14, 2024 · 3 comments · Fixed by #1994
Closed

Post-Jazzy and Pre-Jazzy builds have diverged #1989

evan-palmer opened this issue Sep 14, 2024 · 3 comments · Fixed by #1994

Comments

@evan-palmer
Copy link
Contributor

This is only bug and feature tracker, please use it
to report bugs or request features.


Issue details

I was reviewing the CI for #1988, and saw that the Jazzy/Rolling builds succeed, but the addition causes build failures in releases prior to Jazzy (e.g., humble).

@evan-palmer
Copy link
Contributor Author

It seems like the ros2 branch may need to split to account for the different dependencies. What do you think @vooon? Do you have ideas for an alternative solution?

@vooon
Copy link
Member

vooon commented Sep 16, 2024

Probably better to add conditionals into CMakeLists.txt. Simply check version of rclcpp and then add or skip libyaml.

@evan-palmer
Copy link
Contributor Author

Good idea. I'll submit a PR with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants