Fixes webextensions.api.windows.create notes issues #24961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebloor
added
the
data:webext 🎲
rebloor
changed the title
caugner
previously requested changes
Nov 12, 2024
|
@caugner can you check my fix for your feedback? |
queengooborg
requested changes
Nov 17, 2024
webextensions/api/windows.json
Outdated
| "'url' and 'tabId options can't both be set together.", | ||
| "The returned 'Window' object contains the 'tabs' property only from version 52 onwards.", | ||
| "From Firefox 86, the <code>focused: false</code> option is ignored.", | ||
| "<code>url</code> and <code>tabId</code> options can't be set together.", |
There was a problem hiding this comment.
We just recently switched to allowing Markdown formatting in notes, so let's use that now!
There was a problem hiding this comment.
@queengooborg Completed while resolving merge conflicts
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
caugner
approved these changes
Nov 21, 2024
|
@queengooborg a reminder that I've addressed your changes requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correct a typo and clarify a note for windows.create.
Related issues
Fixes #24888
Fixes #24889