Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html.global_attributes.autocorrect - Safari claims are incorrect #24972

Open
annevk opened this issue Nov 6, 2024 · 3 comments
Open

html.global_attributes.autocorrect - Safari claims are incorrect #24972

annevk opened this issue Nov 6, 2024 · 3 comments
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Comments

@annevk
Copy link

annevk commented Nov 6, 2024

What type of issue is this?

Incorrect support data (example: BrowserX says "86" but support was added in "40")

What information was incorrect, unhelpful, or incomplete?

It claims Safari does not support on/off, but it does.

What browsers does this problem apply to, if applicable?

Safari

What did you expect to see?

That Safari supports this attribute.

Did you test this? If so, how?

It's pretty clear from the source code that Safari does this correct:

Source/WebCore/html/HTMLElement.cpp:    auto& autocorrectValue = attributeWithoutSynchronization(HTMLNames::autocorrectAttr);
Source/WebCore/html/HTMLElement.cpp:    return !equalLettersIgnoringASCIICase(autocorrectValue, "off"_s);
Source/WebCore/html/HTMLElement.cpp:void HTMLElement::setAutocorrect(bool autocorrect)
Source/WebCore/html/HTMLElement.cpp:    setAttributeWithoutSynchronization(autocorrectAttr, autocorrect ? onAtom() : offAtom());
Source/WebCore/html/HTMLElement.h:    bool autocorrect() const { return shouldAutocorrect(); }

And also, Safari contributed this to the standard. I wonder how this was tested to begin with.

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

No response

Do you have anything more you want to share?

No response

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autocorrect

MDN metadata

MDN page report details
  • Query: html.global_attributes.autocorrect
  • Report started: 2024-11-06T14:18:49.053Z
@annevk
Copy link
Author

annevk commented Nov 6, 2024

@hamishwillee it seems you did this in #24249, but note that the getter/setter do operate on a boolean and Safari thus does that correctly. It's the content attribute that supports strings.

@caugner
Copy link
Contributor

caugner commented Nov 6, 2024

Looks like this was only partially fixed by #24834.

@queengooborg queengooborg added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Nov 6, 2024
@GIgako19929
Copy link

Reject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

No branches or pull requests

4 participants