Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.HTMLInputElement.webkitdirectory - Supported on latest Chrome (technically) #24938

Open
danielhjacobs opened this issue Nov 4, 2024 · 3 comments · May be fixed by #25036
Open

api.HTMLInputElement.webkitdirectory - Supported on latest Chrome (technically) #24938

danielhjacobs opened this issue Nov 4, 2024 · 3 comments · May be fixed by #25036
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Nov 4, 2024 •
edited
Loading

What type of issue is this?

Incorrect support data (example: BrowserX says "86" but support was added in "40")

What information was incorrect, unhelpful, or incomplete?

Technically, Chrome on Android now supports <input type="file" webkitdirectory>. However, of very important note is that selecting the folder unconditionally crashes the browser. That is being fixed by https://chromium-review.googlesource.com/c/chromium/src/+/5982392 and I would suggest not updating the support data until that code change is released.

What browsers does this problem apply to, if applicable?

Chromium (Chrome, Edge 79+, Opera, Samsung Internet)

What did you expect to see?

Support on latest Chrome.

Did you test this? If so, how?

Yes, used the example on this page on Chrome on Android and was able to select a folder.

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

https://issues.chromium.org/issues/40101963
https://issues.chromium.org/issues/40248532
https://issues.chromium.org/issues/376834374

Do you have anything more you want to share?

Related: #24847

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory

MDN metadata

MDN page report details
  • Query: api.HTMLInputElement.webkitdirectory
  • Report started: 2024-11-04T14:43:01.681Z
@danielhjacobs danielhjacobs mentioned this issue Nov 4, 2024
Open
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 4, 2024
@danielhjacobs
Copy link
Contributor Author

The fix for https://issues.chromium.org/issues/376834374 was released, but this is still crashing my Android phone as there has not yet been an Android update for Chrome containing a fix.

@danielhjacobs
Copy link
Contributor Author

Tested on Chrome Canary on my Android phone, this is "working" but it's using content-URIs. I opened https://issues.chromium.org/issues/377716464 and there are pending code changes to fix that by updating the file-enumerating code to collect display-names of directories as they are listed, and plumb that information through.

@danielhjacobs danielhjacobs linked a pull request Nov 11, 2024 that will close this issue
Open
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Nov 12, 2024 •
edited
Loading

Both changes (crash fix and path fix) are in M132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chromium supports webkitdirectory on mobile danielhjacobs/browser-compat-data
2 participants
@queengooborg @danielhjacobs