More explicitly differentiate between iterator helper methods/objects #36711
+24
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
requested review from
pepelsbey and
wbamberg
and removed request for
a team
github-actions
bot
added
Content:JS
Preview URLs (8 pages)
External URLs (1)URL:
(comment last updated: 2024-11-11 05:26:34) |
Josh-Cena
commented
Nov 11, 2024
files/en-us/web/javascript/reference/global_objects/iterator/index.md
Outdated
Show resolved
Hide resolved
pepelsbey
approved these changes
Nov 19, 2024
| Among these methods, {{jsxref("Iterator/filter", "filter()")}}, {{jsxref("Iterator/flatMap", "flatMap()")}}, {{jsxref("Iterator/map", "map()")}}, {{jsxref("Iterator/drop", "drop()")}}, and {{jsxref("Iterator/take", "take()")}} return a new _Iterator Helper_ object. The iterator helper is also an `Iterator` instance, making the helper methods chainable. All iterator helper objects inherit from a common prototype object, which implements the iterator protocol: | ||
| ### Iterator helper objects | ||
|
|
||
| > **Note:** _Iterator helper objects_ and _iterator helper methods_ are two different concepts. An Iterator helper object is detectable at runtime, while "iterator helper method" is just a name for a set of methods for comprehension. _Iterator helper_ may refer to either the object or the method, depending on the context. |
There was a problem hiding this comment.
Suggested change
| > **Note:** _Iterator helper objects_ and _iterator helper methods_ are two different concepts. An Iterator helper object is detectable at runtime, while "iterator helper method" is just a name for a set of methods for comprehension. _Iterator helper_ may refer to either the object or the method, depending on the context. | |
| > [!NOTE] | |
| > _Iterator helper objects_ and _iterator helper methods_ are two different concepts. An Iterator helper object is detectable at runtime, while "iterator helper method" is just a name for a set of methods for comprehension. _Iterator helper_ may refer to either the object or the method, depending on the context. |
Let’s use the latest note syntax.
There was a problem hiding this comment.
See the note in the section you linked:
Currently, due to a Prettier bug, the GFM alert syntax cannot be used if the first character of a note or warning is a formatting symbol, such as a backquote, asterisk, square bracket or curly bracket. In this case, use the old syntax
> **Note:**instead. Writers are not required to rephrase the content to work around the formatter.
Also we have MarkdownLint that reports the old syntax where you can change it, so rest assured that you don't have to check it during review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36699. @hamishwillee has expressed the same concern before.